build: fix devcontainer for arm64 machines#54757
Closed
bharath063 wants to merge 1 commit intonodejs:mainfrom
Closed
build: fix devcontainer for arm64 machines#54757bharath063 wants to merge 1 commit intonodejs:mainfrom
bharath063 wants to merge 1 commit intonodejs:mainfrom
Conversation
Author
|
@bnb , Can you please have a look when you can find some time 🙂 |
Member
|
Also see #54347. I've applied your fix and added you as the Co-Author to that PR. |
Author
|
Closing this in favor of #54347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devcontainer image is only built for amd64 architecture. This makes it incompatible with arm64 machines like Apple silicon macs.
Adding the --platform=linux/amd64 makes this run on Apple silicon Macs.
This has been tested with Podman on an M1 Max Macbook pro
Also moved the other settings under the more appropriate
customizationskey as per the devcontainers spec as defined in https://containers.dev/supporting