lib: fix realpathSync resolving to invalid path (#54200)#54458
Open
CGQAQ wants to merge 15 commits intonodejs:mainfrom
Open
lib: fix realpathSync resolving to invalid path (#54200)#54458CGQAQ wants to merge 15 commits intonodejs:mainfrom
CGQAQ wants to merge 15 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
CGQAQ
changed the title
Member
|
Hey! Thanks! |
github-actions
bot
removed
the
request-ci
Collaborator
MoLow
reviewed
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54458 +/- ##
========================================
Coverage 87.32% 87.33%
========================================
Files 648 649 +1
Lines 182359 182611 +252
Branches 34981 35038 +57
========================================
+ Hits 159239 159475 +236
- Misses 16386 16396 +10
- Partials 6734 6740 +6
|
avivkeller
reviewed
Aug 20, 2024
CGQAQ
changed the title
CGQAQ
changed the title
This reverts commit b998fde.
avivkeller
reviewed
Aug 21, 2024
avivkeller
reviewed
Aug 22, 2024
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
👍!
A few tiny nitpicks, but otherwise I think this looks good (but I'm not a core collaborator)
avivkeller
added
the
commit-queue-squash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes that
fs.realpathSyncwill resolve to invalid path in some situation, specifically the input is/dev/stdinonLinuxFixed: #54200