Closed
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
nodejs-github-bot
added
needs-ci
RafaelGSS
approved these changes
Aug 18, 2024
benjamingr
approved these changes
Aug 19, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Author
marco-ippolito
approved these changes
Aug 20, 2024
cjihrig
reviewed
Aug 20, 2024
deps/sqlite/sqlite3.c
Outdated
Comment on lines
24889
to
24890
| /* 4 */ { 5, "month", 176546.0, 30.0*86400.0 }, | ||
| /* 5 */ { 4, "year", 14713.0, 365.0*86400.0 }, |
Contributor
There was a problem hiding this comment.
Windows build is failing. This needs to be reverted. We can float 15b3902 here.
This is equivalent to the following upstream change: https://sqlite.org/src/info/6c103aee6f146869 Original commit message: Change constant expressions to pre-computed constants, because apparently MSVC on ARM requires that. [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e]. FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1
github-actions
bot
removed
the
request-ci
Collaborator
Author
Collaborator
Author
Collaborator
Author
RafaelGSS
added
the
commit-queue-rebase
RafaelGSS
approved these changes
Aug 21, 2024
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in cc26951...6b6b977 |
nodejs-github-bot
added a commit
that referenced
this pull request
Aug 21, 2024
PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
This is equivalent to the following upstream change: https://sqlite.org/src/info/6c103aee6f146869 Original commit message: Change constant expressions to pre-computed constants, because apparently MSVC on ARM requires that. [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e]. FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1 PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
This is equivalent to the following upstream change: https://sqlite.org/src/info/6c103aee6f146869 Original commit message: Change constant expressions to pre-computed constants, because apparently MSVC on ARM requires that. [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e]. FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1 PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
This is equivalent to the following upstream change: https://sqlite.org/src/info/6c103aee6f146869 Original commit message: Change constant expressions to pre-computed constants, because apparently MSVC on ARM requires that. [forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e]. FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1 PR-URL: #54433 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos
added
the
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of sqlite to 3.46.1.