test: update wpt test for WebCryptoAPI#54127
Closed
Nahee-Park wants to merge 2 commits intonodejs:mainfrom
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Member
|
Hi @Nahee-Park, and thank you for your first contribution! Unfortunately, this isn't going to work, last time I tried there are certain architectures in CI where these vectors don't fail and we don't have a way of setting failures conditionally in WPTs like we do in regular tests. |
Contributor
Author
|
Hi @panva ! Thank you for your feedback and guidance. Upon reviewing your comments, I understand the challenges related to certain architectures where these vectors may not fail, as well as the limitations of WPTs in handling conditional failures. I appreciate the insights and would like to contribute in new ways. I will go ahead and close this PR. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the web platform tests for the WebCryptoAPI.