src: fix implementation of PropertySetterCallback#53576
Closed
targos wants to merge 1 commit intonodejs:mainfrom
Closed
src: fix implementation of PropertySetterCallback#53576targos wants to merge 1 commit intonodejs:mainfrom
PropertySetterCallback#53576targos wants to merge 1 commit intonodejs:mainfrom
Conversation
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658
targos
added
the
commit-queue-rebase
nodejs-github-bot
added
c++
targos
added
dont-land-on-v18.x
dont-land-on-v20.x
Contributor
I suppose that doesn't apply to the version of V8 we're currently compiling, otherwise I don't understand how we're able to build. Or is it only a warning for now? |
Member
Author
|
Maybe @isheludko has the answer? |
Contributor
|
The call to This CL is a preparation for V8 CL which actually bans misuses of the ReturnValue: https://crrev.com/c/5647894. Heads-up: at some point V8 will support returning a boolean value from Setter/Definer callbacks for real : https://crbug.com/348660658. |
lpinca
approved these changes
Jun 25, 2024
legendecas
approved these changes
Jun 25, 2024
VoltrexKeyva
approved these changes
Jun 26, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e849dd6...eaffed6 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: #53576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: #53576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: #53576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
V8 does not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is `true`, it's not even necessary to set the return value on a successful path. Refs: https://crbug.com/348660658 PR-URL: nodejs#53576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 does not allow returning arbitrary values from the interceptor
setter callbacks, only a boolean return value is allowed. Since
default return value is
true, it's not even necessary to setthe return value on a successful path.
Refs: https://crbug.com/348660658
This was adapted from v8#194