Skip to content

quic: address coverity warning#52824

Closed
mhdawson wants to merge 1 commit intonodejs:mainfrom
mhdawson:coverity-52
Closed

quic: address coverity warning#52824
mhdawson wants to merge 1 commit intonodejs:mainfrom
mhdawson:coverity-52

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented May 3, 2024

  • initiaze variable in similar way down in other constructors

@mhdawson
quic: address coverity warning
16342f4 
- initiaze variable in similar way down in other
  constructors

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels May 3, 2024
@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2024

Coverity report

170QuicError::QuicError(const ngtcp2_ccerr* ptr)
171    : reason_(reinterpret_cast<const char*>(ptr->reason), ptr->reasonlen),
     	2. uninit_member: Non-static class member error_.type is not initialized in this constructor nor in any functions that it calls.
     	4. uninit_member: Non-static class member error_.error_code is not initialized in this constructor nor in any functions that it calls.
     	6. uninit_member: Non-static class member error_.frame_type is not initialized in this constructor nor in any functions that it calls.
     	8. uninit_member: Non-static class member error_.reason is not initialized in this constructor nor in any functions that it calls.
     	
CID 338953: (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
10. uninit_member: Non-static class member error_.reasonlen is not initialized in this constructor nor in any functions that it calls.
172      ptr_(ptr) {}
173

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58988/

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58990/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 8, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59044/

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 9, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59064/

mhdawson added a commit that referenced this pull request May 10, 2024
@mhdawson
quic: address coverity warning
fd1e66f 
- initiaze variable in similar way down in other
  constructors

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52824
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@mhdawson
Copy link
Member Author

mhdawson commented May 10, 2024

Landed in Landed in fd1e66f

@mhdawson mhdawson closed this May 10, 2024
targos pushed a commit that referenced this pull request May 11, 2024
@mhdawson @targos
quic: address coverity warning
619ac79 
- initiaze variable in similar way down in other
  constructors

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52824
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request May 13, 2024
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label May 23, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@mhdawson @eliphazbouye
quic: address coverity warning
e4bc381 
- initiaze variable in similar way down in other
  constructors

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52824
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@mhdawson @bmeck
quic: address coverity warning
da94468 
- initiaze variable in similar way down in other
  constructors

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52824
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson @nodejs-github-bot @jasnell @lpinca @anonrig @tniessen @marco-ippolito @avivkeller