test_runner: improve describe.only behavior

[MoLow]

Supersedes #48932

this fixes two major issues with describe that will now run regardless of it not being marked with only:

1. if a test is marked with only, it is not needed to mark all of its ancestors with only
2. if a suite is marked as only, and no nested test is marked with only, all its decendents will run

this aligns the behavior with other test runners I have compared with

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[MoLow]

some examples:

describe('1', () => {
  it('2');
  describe('3', () => {
    it('4');
    describe('5', () => {
      it('6');
      it.only('7');
    });
  });
});

===>

▶ 1
  ▶ 3
    ▶ 5
      ✔ 7 (0.30825ms)
    ▶ 5 (0.813458ms)
  ▶ 3 (1.103583ms)
▶ 1 (1.578209ms)

describe('1', () => {
  it('2');
  describe.only('3', () => {
    it('4');
    describe('5', () => {
      it('6');
      it('7');
    });
  });
});

===>

▶ 1
  ▶ 3
    ✔ 4 (0.414666ms)
    ▶ 5
      ✔ 6 (0.070375ms)
      ✔ 7 (0.112041ms)
    ▶ 5 (0.339458ms)
  ▶ 3 (1.070458ms)
▶ 1 (1.617208ms)

etc

[cjihrig]

LGTM, but it's probably worth updating some docs for this.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58037/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58039/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58040/

[rluvaton]

Can you add a test that before and after hooks are not running for unfocused suites? IIRC they do run when there are no tests in describe while I think they shouldn't in this case

[MoLow]

@rluvaton can you add these tests in a follow-up PR?. I am not sure what an unfocused suite is

[rluvaton]

sure (what I meant with unfocused are suites that or not in the only scope)

[MoLow]

FWIW this code

describe('describe 1', () => {
  before(() => console.log('before describe 1'))
  beforeEach(() => console.log('beforeEach describe 1'))
  it.only(async () => {
    console.log(1);
  })
  it('no', () => {});
  afterEach(() => console.log('afterEach describe 1'))
  after(() => console.log('after describe 1'))
})


describe('describe 2', () => {
  before(() => console.log('before describe 2'))
  beforeEach(() => console.log('beforeEach describe 2'))
  it('no', () => {});
  afterEach(() => console.log('afterEach describe 2'))
  after(() => console.log('after describe 2'))
})

outputs

before describe 1
beforeEach describe 1
1
afterEach describe 1
after describe 1
▶ describe 1
  ✔ <anonymous> (0.769792ms)
▶ describe 1 (5.330458ms)

which seems ok to me
CI is locked down so I prefer not to perform additional changes in this branch

[nodejs-github-bot]

Landed in ac9e5e7

[marco-ippolito]

Can you please create a manual backport to v20x?