Merged
Conversation
nodejs-github-bot
added
child_process
aduh95
reviewed
Mar 20, 2024
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't really understand the "optimize" part of the commit message. In what sense does this change optimize the docs?
Contributor
Author
I'm trying to improve the documentation and point out that we can't send IPC handles on win32 platform 😄. |
theanarkh
force-pushed
the
optimize_child_process_doc
branch
from
5c40dd6 to
8f3b8a4
Compare
Contributor
Then maybe |
theanarkh
force-pushed
the
optimize_child_process_doc
branch
from
8f3b8a4 to
3f9b2e5
Compare
lpinca
approved these changes
Mar 23, 2024
1. Clarify that which types of objects can be sent through process.send 2. Clarify that IPC handle are not supported on win32 platform
theanarkh
force-pushed
the
optimize_child_process_doc
branch
from
3f9b2e5 to
0bb700e
Compare
aduh95
approved these changes
Mar 26, 2024
Contributor
|
Landed in 312ebd9 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: nodejs#52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: #52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
- Clarify which types of objects can be sent through `process.send`. - Clarify that IPC handles are not supported on win32 platform. PR-URL: #52154 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @bnoordhuis
make -j4 test(UNIX), orvcbuild test(Windows) passes