Merged
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
nodejs-github-bot
added
needs-ci
marco-ippolito
approved these changes
Feb 18, 2024
lpinca
approved these changes
Feb 18, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Author
RafaelGSS
approved these changes
Feb 18, 2024
Collaborator
Author
Collaborator
Author
Collaborator
Author
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Author
|
Landed in 0350609 |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
added
dont-land-on-v20.x
richardlau
pushed a commit
that referenced
this pull request
May 10, 2024
PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
Member
|
it doesnt land cleanly on v20.x, I tried to fix conflict but it fails during build, so I'll request backport |
marco-ippolito
added
the
backport-requested-v20.x
Member
|
I wonder what explains the presence of a conflict here. |
Member
The only reason could be security release? the version on v20.x-staging is 1.1.0, I haven't investigated though |
Member
|
The missing PRs before this one are: They're both labeled |
marco-ippolito
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ngtcp2 to 1.3.0.