doc: change ExperimentalWarnings to ExperimentalWarning#51741
doc: change ExperimentalWarnings to ExperimentalWarning#51741nodejs-github-bot merged 1 commit intonodejs:mainfrom akaustav:patch-1
ExperimentalWarnings to ExperimentalWarning#51741Conversation
|
you need to edit your first commit message you can do it like this : |
Sure, @mertcanaltin. Working on modifying the commit message and rebasing my PR now. Will post here when done. |
ExperimentalWarnings to ExperimentalWarningExperimentalWarnings to ExperimentalWarning
@mertcanaltin - Just rebased and force pushed the commit with the modified commit message. PS. Notes for myself
|
|
Landed in 123dc51 |
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: #51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
PR-URL: nodejs#51741 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Change Summary
This PR changes
ExperimentalWarningstoExperimentalWarningin the documentation for the latest version of NodeJS as of this writing -v21.6.1.Why?
I am using the experimental JSON Modules feature within my NodeJS project. Although the JSON Modules feature works, whenever I execute my ES Module based JavaScript file, I would receive the following warning:
After reading through the documentation under the section titled
--disable-warning=code-or-type, I tried to suppress theExperimentalWarningby changing the followingstartscript within mypackage.jsonfile:{ ... "scripts": { "start": "node --disable-warning=ExperimentalWarnings src/index.js" }, ... }But I still received the aforementioned
ExperimentalWarningwithin my console.After re-reading the documentation (and referring other documentations - like this comment on issue #30810), instead of the plural version (
ExperimentalWarnings), I tried the singular version (ExperimentalWarning):{ ... "scripts": { - "start": "node --disable-warning=ExperimentalWarnings src/index.js" + "start": "node --disable-warning=ExperimentalWarning src/index.js" }, ... }And it worked! The warning was suppressed.
Hence, this PR to address the confusion in the documentation.