Closed
Conversation
Collaborator
Author
|
Review requested:
|
Member
|
I think this update should be split into several commits to prevent commit message lint failure |
Contributor
|
This is blocked by micromark/micromark#157, see #49988 (comment) |
MoLow
approved these changes
Jan 14, 2024
marco-ippolito
approved these changes
Feb 4, 2024
Member
|
running a full CI cycle to check if this can get unblocked |
Collaborator
Author
Member
|
still failing |
53c8f72 to
fe425f3
Compare
Member
|
amended commit otherwise we will never land this, I'll fix the tool in another PR |
MoLow
approved these changes
Jun 2, 2024
marco-ippolito
approved these changes
Jun 9, 2024
jasnell
approved these changes
Jul 7, 2024
MoLow
approved these changes
Jul 28, 2024
UlisesGascon
approved these changes
Aug 25, 2024
Member
|
(The blocking PR has been closed) |
Contributor
And the problem hasn't been addressed, the CI doesn't pass. |
Collaborator
Author
Collaborator
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51192 +/- ##
==========================================
- Coverage 88.42% 87.92% -0.50%
==========================================
Files 654 654
Lines 187852 187852
Branches 36134 35824 -310
==========================================
- Hits 166102 165167 -935
- Misses 14989 15875 +886
- Partials 6761 6810 +49 |
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/51192 ✔ Done loading data for nodejs/node/pull/51192 ----------------------------------- PR info ------------------------------------ Title tools: update doc to new version (#51192) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-doc -> nodejs:main Labels doc, tools, author ready, needs-ci, commit-queue-rebase, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 2 - tools: disable doc building when ICU is not available - tools: update doc to new version Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tools: disable doc building when ICU is not available ⚠ - tools: update doc to new version ℹ This PR was created on Sun, 17 Dec 2023 00:26:43 GMT ✔ Approvals: 4 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2203485934 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2106067988 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51192#pullrequestreview-2161903820 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/51192#pullrequestreview-2259349505 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-16T23:04:18Z: https://ci.nodejs.org/job/node-test-pull-request/63590/ - Querying data for job/node-test-pull-request/63590/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11878353074 |
marco-ippolito
approved these changes
Nov 17, 2024
Collaborator
Author
|
Landed in b0051de...b1ee186 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2024
PR-URL: #51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Nov 17, 2024
PR-URL: #51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#51192 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of doc to new version.