tools: check timezone current version#51178
Merged
nodejs-github-bot merged 2 commits intomainfrom Dec 20, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
marco-ippolito
force-pushed
the
fix-timezone-check
branch
from
f66280d to
c69d458
Compare
richardlau
reviewed
Dec 16, 2023
Member
Author
richardlau
approved these changes
Dec 16, 2023
lpinca
approved these changes
Dec 16, 2023
MoLow
approved these changes
Dec 16, 2023
debadree25
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51178 ✔ Done loading data for nodejs/node/pull/51178 ----------------------------------- PR info ------------------------------------ Title tools: check timezone current version (#51178) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix-timezone-check -> nodejs:main Labels meta, tools, author ready Commits 2 - tools: check timezone current version - fix: use tz-version.txt Committers 1 - marco-ippolito PR-URL: https://github.com/nodejs/node/pull/51178 Refs: https://github.com/nodejs/node/pull/51107 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51178 Refs: https://github.com/nodejs/node/pull/51107 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 Dec 2023 11:03:02 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785181766 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785189342 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51178#pullrequestreview-1785312420 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51178 From https://github.com/nodejs/node * branch refs/pull/51178/merge -> FETCH_HEAD ✔ Fetched commits as 7a216d5fd633..05faefbb0635 -------------------------------------------------------------------------------- [main 890862f32f] tools: check timezone current version Author: marco-ippolito Date: Sat Dec 16 11:50:38 2023 +0100 1 file changed, 10 insertions(+) [main 63af976a38] fix: use tz-version.txt Author: marco-ippolito Date: Sat Dec 16 14:44:00 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7259068349 |
marco-ippolito
added
the
commit-queue-squash
UlisesGascon
approved these changes
Dec 20, 2023
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 12fc7cb |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #51107
@richardlau