Enable passthrough IPC in watch mode#50890
Conversation
nodejs-github-bot
added
needs-ci
|
I think this should be directed towards the main branch |
I confess, I'm not totally clear on the branching structure. I'd like this to be available in node 18, are you suggesting I point at |
|
So the general process is we land changes onto the main branch of this repo and then changes are backported to the release lines you can read about it here https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md |
|
please also resolve conflicts |
|
This will almost certainly require a backport PR noting the original commit for my reference later: |
znewsham
force-pushed
the
znewsham/watch-with-ipc
branch
from
ad21317 to
1c04659
Compare
debadree25
added
watch-mode
debadree25
left a comment
debadree25
left a comment
There was a problem hiding this comment.
Could you fix the first commit message according to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines , and these few linting issues that it complains about.
znewsham
force-pushed
the
znewsham/watch-with-ipc
branch
2 times, most recently
from
1b82c7f to
2fa9259
Compare
|
Both of those are fixed - for some reason I can't get eslint to play nice with vscode - but the linting is now resolved. |
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
Changes LGTM, but I think the test can be simplified more
|
Just want to check on the next steps here - the contribution guide suggests I should kick off the CI build and add an "Author Ready" label - I don't believe I have permissions to do either |
debadree25
added
request-ci
github-actions
bot
removed
the
request-ci
|
What's the best way to debug failures on specific architectures? E.g., I could probably get myself access to an arm machine if necessary |
|
@MoLow I apologise, the failing test was caused by a previously fixed test that the rebase must have removed (an extraneous |
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9014337858 |
MoLow
added
request-ci
github-actions
bot
removed
the
request-ci
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 70995bd |
|
@MoLow thanks for your help in getting this across the line - I've read through the contribution guide (and the backporting guide), but it still isn't clear to me which release this will appear in (or when) - will it be a minor version increase in v22, or does it have to wait until v23? Is backporting to v20 (or even v18, it's not clear what "maintenance" means) an option? |
PR-URL: #50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
It should get to all active releases (20, 21, 22) |
PR-URL: #50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
6 participants
Fixes #50880
When spawning a node process in watch mode, from another node process, there is currently no way to get IPC between the parent and the child. This PR enables this bi-directional flow:
This setup is useful in situations where you have a process responsible for building and running a client/server application which needs to be made aware (via IPC) that it's client bundle has changed and needs to be re-served, without restarting the server.