stream: bump default highWaterMark#50120
Closed
RafaelGSS wants to merge 5 commits intonodejs:mainfrom
Closed
Conversation
RafaelGSS
added
stream
Collaborator
|
Review requested:
|
RafaelGSS
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
30 tasks
ronag
approved these changes
Oct 11, 2023
MoLow
approved these changes
Oct 11, 2023
jasnell
approved these changes
Oct 28, 2023
benjamingr
approved these changes
Oct 29, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 30, 2023
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit.
RafaelGSS
force-pushed
the
bump-highWaterMark-value
branch
from
4ad103c to
5d6e5c9
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
Member
Member
|
@RafaelGSS the last commit does not make much sense. I don't think we should update the benchmark to use 64 MiB instead of 16 MiB. |
Member
Author
Yeah, it was a naive attempt. Since we're getting ENOBUFS on Windows benchmarks, I believe we should reduce it? Considering the memory consumption should have increased. |
This reverts commit 4411343.
Member
|
Yes, I think so. |
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
added a commit
to websockets/ws
that referenced
this pull request
Dec 26, 2023
trivikr
approved these changes
Dec 27, 2023
|
Any plans to get this to v22? |
github-actions
bot
removed
the
request-ci
Collaborator
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 10, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. Refs: nodejs#46608 Refs: nodejs#50120
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 10, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 10, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 11, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 11, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
Member
|
Should this be closed in favor of #52037? |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 13, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Mar 13, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: #52037 Refs: #46608 Refs: #50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #46608