typings: lib/internal/vm.js by GeoffreyBooth · Pull Request #50112 · nodejs/node

GeoffreyBooth · 2023-10-10T03:48:21Z

Tiny PR to add a little JSDoc.

lib/internal/vm.js

aduh95 · 2023-11-29T10:00:36Z

This needs a rebase

lib/internal/vm.js

fhinkel · 2024-02-03T11:19:01Z

@GeoffreyBooth thanks so much for opening a PR! To be honest, I don't think the doc annotation adds much in this case given they're just a long form of the variable/function names. Would it be OK if we close this without merging it? Thanks for understanding.

GeoffreyBooth · 2024-02-03T15:44:31Z

I don't think the doc annotation adds much in this case

The main thing it adds is hinting for the types of arguments in your editor as you work. This was waiting on another PR from @joyeecheung but it might be unblocked now. I'm not sure when I'll have time to rebase but anyone else can finish this.

lib/internal/vm.js

legendecas

LGTM % one suggestion

lib/internal/vm.js

legendecas

LGTM if lint complaints are fixed.

lib/internal/vm.js

GeoffreyBooth · 2024-02-05T17:36:08Z

LGTM if lint complaints are fixed.

Thanks, that looks like it fixed the lint check, if you don’t mind reapproving.

fhinkel · 2024-02-05T23:13:55Z

I don't think the doc annotation adds much in this case

The main thing it adds is hinting for the types of arguments in your editor as you work. This was waiting on another PR from @joyeecheung but it might be unblocked now. I'm not sure when I'll have time to rebase but anyone else can finish this.

Gotcha! Thanks for following up. LGTM.

nodejs-github-bot · 2024-02-07T14:04:31Z

Commit Queue failed

- Loading data for nodejs/node/pull/50112
✔  Done loading data for nodejs/node/pull/50112
----------------------------------- PR info ------------------------------------
Title      typings: lib/internal/vm.js (#50112)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     GeoffreyBooth:type-internal-compile-function -> nodejs:main
Labels     vm, author ready, typings, commit-queue-squash
Commits    7
 - typings: lib/internal/vm.js
 - @legendecas suggestion
 - lint
 - Apply suggestions from code review
 - Update lib/internal/vm.js
 - Apply suggestions from code review
 - Apply suggestions from code review
Committers 2
 - Geoffrey Booth 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/50112
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50112
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 10 Oct 2023 03:48:21 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265
   ✔  - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7815976165

nodejs-github-bot · 2024-02-14T19:48:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57088/

nodejs-github-bot · 2024-02-17T23:01:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57164/

nodejs-github-bot · 2024-02-17T23:55:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57165/

nodejs-github-bot · 2024-02-18T14:21:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/50112
✔  Done loading data for nodejs/node/pull/50112
----------------------------------- PR info ------------------------------------
Title      typings: lib/internal/vm.js (#50112)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     GeoffreyBooth:type-internal-compile-function -> nodejs:main
Labels     vm, author ready, typings, commit-queue-squash
Commits    3
 - typings: lib/internal/vm.js
 - @legendecas suggestion
 - lint
Committers 1
 - Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/50112
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50112
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - typings: lib/internal/vm.js
   ⚠  - @legendecas suggestion
   ⚠  - lint
   ℹ  This PR was created on Tue, 10 Oct 2023 03:48:21 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1861179506
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864665265
   ✔  - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/50112#pullrequestreview-1864005359
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50112#pullrequestreview-1865292289
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-02-17T23:55:37Z: https://ci.nodejs.org/job/node-test-pull-request/57165/
- Querying data for job/node-test-pull-request/57165/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7949622474

GeoffreyBooth · 2024-02-18T16:26:00Z

Can someone please reapprove this so it can land?

nodejs-github-bot · 2024-02-19T01:19:45Z

Landed in 0550bc1

PR-URL: #50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #50112 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

GeoffreyBooth added vm Issues and PRs related to the vm subsystem. typings labels Oct 10, 2023

GeoffreyBooth requested a review from joyeecheung October 10, 2023 03:48

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 10, 2023

GeoffreyBooth force-pushed the type-internal-compile-function branch from 1999445 to a280623 Compare October 10, 2023 04:09

anonrig approved these changes Oct 10, 2023

View reviewed changes

anonrig removed the needs-ci PRs that need a full CI run. label Oct 10, 2023

GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2023

joyeecheung reviewed Oct 12, 2023

View reviewed changes

lib/internal/vm.js Outdated Show resolved Hide resolved

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2023

legendecas reviewed Dec 11, 2023

View reviewed changes

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Outdated Show resolved Hide resolved

fhinkel closed this Feb 3, 2024

GeoffreyBooth reopened this Feb 3, 2024

GeoffreyBooth force-pushed the type-internal-compile-function branch from a280623 to c9ca65c Compare February 3, 2024 18:49

GeoffreyBooth requested review from joyeecheung and legendecas February 3, 2024 18:53

anonrig approved these changes Feb 4, 2024

View reviewed changes

legendecas reviewed Feb 4, 2024

View reviewed changes

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

GeoffreyBooth requested a review from legendecas February 4, 2024 17:59

legendecas reviewed Feb 5, 2024

View reviewed changes

lib/internal/vm.js Show resolved Hide resolved

GeoffreyBooth requested a review from legendecas February 5, 2024 02:37

joyeecheung reviewed Feb 5, 2024

View reviewed changes

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

lib/internal/vm.js Show resolved Hide resolved

GeoffreyBooth requested a review from joyeecheung February 5, 2024 16:33

legendecas approved these changes Feb 5, 2024

View reviewed changes

lib/internal/vm.js Outdated Show resolved Hide resolved

lib/internal/vm.js Outdated Show resolved Hide resolved

fhinkel approved these changes Feb 5, 2024

View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 7, 2024

legendecas added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 7, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024

GeoffreyBooth added 3 commits February 17, 2024 14:48

typings: lib/internal/vm.js

c1797e0

@legendecas suggestion

fb07f0c

lint

2550c46

GeoffreyBooth force-pushed the type-internal-compile-function branch from dfdf6a7 to 2550c46 Compare February 17, 2024 23:00

GeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 18, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2024

Trott approved these changes Feb 18, 2024

View reviewed changes

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 19, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 19, 2024

nodejs-github-bot merged commit 0550bc1 into nodejs:main Feb 19, 2024

marco-ippolito mentioned this pull request Mar 1, 2024

v21.7.0 proposal #51932

Merged

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

Uh oh!

Conversation

GeoffreyBooth commented Oct 10, 2023

Uh oh!

Uh oh!

aduh95 commented Nov 29, 2023

Uh oh!

Uh oh!

Uh oh!

fhinkel commented Feb 3, 2024

Uh oh!

GeoffreyBooth commented Feb 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GeoffreyBooth commented Feb 5, 2024

Uh oh!

fhinkel commented Feb 5, 2024

Uh oh!

nodejs-github-bot commented Feb 7, 2024

Uh oh!

nodejs-github-bot commented Feb 14, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 17, 2024

Uh oh!

nodejs-github-bot commented Feb 18, 2024

Uh oh!

GeoffreyBooth commented Feb 18, 2024

Uh oh!

nodejs-github-bot commented Feb 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants