src: use SNAPSHOT_SERDES to log snapshot ser/deserialization#49637
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 18, 2023
Merged
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization#49637nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
To avoid clobbering output of MKSNAPSHOT
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Sep 14, 2023
Member
Author
|
@nodejs/startup @nodejs/cpp-reviewers Can I have some reviews please? |
RaisinTen
approved these changes
Sep 15, 2023
Member
Author
|
Ran clang-format to make linter happy.. |
github-actions
bot
removed
the
request-ci
Collaborator
25 tasks
jasnell
approved these changes
Sep 16, 2023
32 tasks
Collaborator
33 tasks
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b03a757 |
This was referenced Sep 19, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
To avoid clobbering output of MKSNAPSHOT PR-URL: #49637 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
To avoid clobbering output of MKSNAPSHOT PR-URL: nodejs#49637 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid clobbering output of MKSNAPSHOT