Skip to content

[v18.x backport] fs, stream: initial Symbol.dispose and Symbol.asyncDispose support#49598

Closed
atlowChemi wants to merge 1 commit intonodejs:v18.x-stagingfrom
atlowChemi:backport-48518-to-18
Closed

[v18.x backport] fs, stream: initial Symbol.dispose and Symbol.asyncDispose support#49598
atlowChemi wants to merge 1 commit intonodejs:v18.x-stagingfrom
atlowChemi:backport-48518-to-18

Conversation

@atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented Sep 11, 2023

PR-URL: #48518
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Erick Wendel erick.workspace@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

@MoLow @benjamingr @atlowChemi
fs, stream: initial Symbol.dispose and Symbol.asyncDispose support
5fecb22 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#48518
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 11, 2023

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 11, 2023
@atlowChemi atlowChemi mentioned this pull request Sep 11, 2023
Merged
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 11, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53878/

ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@MoLow @benjamingr @ruyadorno
fs, stream: initial Symbol.dispose and Symbol.asyncDispose support
6747721 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #48518
Backport-PR-URL: #49598
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@ruyadorno
Copy link
Member

ruyadorno commented Sep 11, 2023

Landed in 6747721

@ruyadorno ruyadorno closed this Sep 11, 2023
@atlowChemi atlowChemi deleted the backport-48518-to-18 branch September 11, 2023 16:35
@MoLow MoLow mentioned this pull request Sep 11, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@MoLow @benjamingr @ruyadorno
fs, stream: initial Symbol.dispose and Symbol.asyncDispose support
eed884b 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #48518
Backport-PR-URL: #49598
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@MoLow @benjamingr @ruyadorno
fs, stream: initial Symbol.dispose and Symbol.asyncDispose support
3a8586b 
Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #48518
Backport-PR-URL: #49598
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atlowChemi @nodejs-github-bot @ruyadorno @MoLow