benchmark: shorten pipe-to by reducing number of chunks#49577
benchmark: shorten pipe-to by reducing number of chunks#49577nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
the
benchmark
|
Benchmark link (with 2 iterations to see the general time it should take): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1371/ Edit: each combination takes 1 second so it should now take around 15m |
|
FWIW you shouldn't always reduce iterations just to make them take less time. In most cases the number of iterations is where it is for a reason, namely because V8 does not optimize code right away (or the opposite: it could eventually deoptimize code for some reason) so you can easily get misleading results if the process does not stay alive long enough. |
|
Do you think it's applicable here? Because 2.5 hours is way too long |
I would say it's always applicable because it's not really safe to guess what V8 may or may not do, especially across V8 versions. |
debadree25
left a comment
debadree25
left a comment
There was a problem hiding this comment.
+1 as well, ran into the same trying to run the entire suite of webstreams benchmark locally
debadree25
added
the
author ready
rluvaton
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7ad4c0f |
PR-URL: #49577 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: nodejs#49577 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
5 participants
(this only now start taking a long time due to #49552)
without this, it takes 2.5 hours with this it should take around 15 minutes:
each iteration (single combination) takes 9 seconds (saw here).
there are 16 possible combinations.
so 9 seconds * 16 combination * 30 default runs * 2 versions = 2 hours and 24 minutes...