test: increase coverage of Module.register and initialize hook#49532
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 10, 2023
Merged
test: increase coverage of Module.register and initialize hook#49532nodejs-github-bot merged 1 commit intonodejs:mainfrom
Module.register and initialize hook#49532nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Contributor
Author
|
/cc @nodejs/loaders |
Member
|
How does this relate to #49529? |
GeoffreyBooth
approved these changes
Sep 7, 2023
Contributor
Author
Hum both PRs are dealing with the same |
Member
As in, none of these tests involve the That’s fine, I was just hoping that they weren’t in conflict, and it sounds like they aren’t. |
Collaborator
Contributor
Author
They probably are in conflict, they are modifying the same lines in the test, for unrelated reasons. |
a6f90e9 to
f56fa28
Compare
Collaborator
19 tasks
Collaborator
anonrig
approved these changes
Sep 10, 2023
Collaborator
Collaborator
|
Landed in c159b90 |
This was referenced Sep 11, 2023
This was referenced Sep 13, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49532 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49532 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49532 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49532 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49532 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend reviewing with whitespaces turned off.