test_runner: preserve original property descriptor when mutating objects#49433
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Sep 3, 2023
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ErickWendel
force-pushed
the
test_runner/mock-preserve-original-property-descriptor
branch
from
768af5c to
3fda352
Compare
ljharb
approved these changes
Sep 1, 2023
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
would be good to add a test or two checking enumerability, since that's likely the only thing different with this change
Member
Author
Uh, good catch! Gonna do it in a few |
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
ErickWendel
force-pushed
the
test_runner/mock-preserve-original-property-descriptor
branch
from
93a9e75 to
64f872a
Compare
Member
Author
done! |
benjamingr
approved these changes
Sep 2, 2023
github-actions
bot
removed
the
request-ci
Collaborator
rluvaton
approved these changes
Sep 2, 2023
atlowChemi
approved these changes
Sep 2, 2023
atlowChemi
added
the
author ready
Collaborator
MoLow
approved these changes
Sep 3, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49433 ✔ Done loading data for nodejs/node/pull/49433 ----------------------------------- PR info ------------------------------------ Title test_runner: preserve original property descriptor when mutating objects (#49433) Author Erick Wendel (@ErickWendel) Branch ErickWendel:test_runner/mock-preserve-original-property-descriptor -> nodejs:main Labels author ready, needs-ci, test_runner Commits 3 - test_runner: preserve original property descriptor - test_runner: add test for checking the property descriptor state - test_runner: refactoring functions Committers 1 - Erick Wendel PR-URL: https://github.com/nodejs/node/pull/49433 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49433 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 Sep 2023 17:13:36 GMT ✔ Approvals: 4 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608049890 ✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608346449 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608366919 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49433#pullrequestreview-1608411583 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-02T19:22:27Z: https://ci.nodejs.org/job/node-test-pull-request/53694/ - Querying data for job/node-test-pull-request/53694/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49433 From https://github.com/nodejs/node * branch refs/pull/49433/merge -> FETCH_HEAD ✔ Fetched commits as 0add7a8f0c92..64f872a28f86 -------------------------------------------------------------------------------- [main 9ce045d826] test_runner: preserve original property descriptor Author: Erick Wendel Date: Fri Sep 1 14:07:12 2023 -0300 1 file changed, 137 insertions(+), 35 deletions(-) [main 9a7621b25c] test_runner: add test for checking the property descriptor state Author: Erick Wendel Date: Fri Sep 1 15:55:26 2023 -0300 1 file changed, 49 insertions(+) [main 2de5750354] test_runner: refactoring functions Author: Erick Wendel Date: Fri Sep 1 15:59:39 2023 -0300 2 files changed, 162 insertions(+), 141 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/6065810018 |
atlowChemi
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8e82cfc |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49433 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49433 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49433 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49433 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49433 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this comment, #49397 (comment) @ljharb suggested preserving the behavior and attributes of properties as they were before the modification
cc @nodejs/test_runner