crypto: remove webcrypto EdDSA key checks and properties#49408
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 1, 2023
Merged
crypto: remove webcrypto EdDSA key checks and properties#49408nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
panva
added
crypto
Collaborator
|
Review requested:
|
panva
force-pushed
the
crypto-update-eddsa-alg
branch
from
ea4d94e to
48cd7c0
Compare
panva
added
request-ci
panva
force-pushed
the
crypto-update-eddsa-alg
branch
from
48cd7c0 to
a859a18
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
approved these changes
Aug 31, 2023
panva
added
the
author ready
tniessen
approved these changes
Aug 31, 2023
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 457cedd |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
As per WICG/webcrypto-secure-curves#24 PR-URL: #49408 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This was referenced Oct 4, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
As per WICG/webcrypto-secure-curves#24 PR-URL: nodejs#49408 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per WICG/webcrypto-secure-curves#24 this removes the check for EdDSA
algduring JWK importKey and removes thealgfor Ed25519 and Ed448 keys during JWK exportKey.The algorithms from https://github.com/WICG/webcrypto-secure-curves/ are marked as experimental in our implementation which is why this can forgo semver-major and also be easily backported.