doc: update description of percent_encode set in WHATWG API#49258
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Aug 23, 2023
Merged
doc: update description of percent_encode set in WHATWG API#49258nodejs-github-bot merged 2 commits intonodejs:mainfrom
percent_encode set in WHATWG API#49258nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
doc
Member
|
Please fix the markdown lint error. |
Contributor
Author
|
@daeyeon Hi, Thank you for your comment. I fixed it. |
daeyeon
approved these changes
Aug 22, 2023
daeyeon
added
author ready
lpinca
approved these changes
Aug 22, 2023
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 56a2a2e |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49258 Refs: https://url.spec.whatwg.org/#percent-encoded-bytes Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The character code is shown in the description of percent-encoded-bytes in the
WHATWG URLSpec.I think it would be better for readability to show the 'character code' the same as the
WHATWG URL.Refs: https://url.spec.whatwg.org/#percent-encoded-bytes