doc,test: add known path resolution issue in permission model by tniessen · Pull Request #49155 · nodejs/node

tniessen · 2023-08-13T23:09:33Z

As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference.

nodejs-github-bot · 2023-08-13T23:09:37Z

Review requested:

@nodejs/security-wg

RafaelGSS

LGTM.

test/known_issues/test-permission-model-path-resolution.js

tniessen · 2023-08-27T13:08:27Z

The git-rebase job failed 🤔

13:05:02 + git push binary_tmp@147.75.72.255:binary_tmp.git +jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd
13:05:03 remote: fatal: bad object refs/heads/jenkins-node-test-commit-arm-fanned-44627007be7eb3934e39bdd3df7e8f2556a2cd44-binary-pi1p/cc-armv7        
13:05:03 fatal: bad object refs/heads/jenkins-node-test-commit-arm-fanned-44627007be7eb3934e39bdd3df7e8f2556a2cd44-binary-pi1p/cc-armv7
13:05:03 To 147.75.72.255:binary_tmp.git
13:05:03  ! [remote rejected]         jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd -> jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd (missing necessary objects)
13:05:03 error: failed to push some refs to 'binary_tmp@147.75.72.255:binary_tmp.git'

richardlau · 2023-08-27T14:15:20Z

The git-rebase job failed 🤔

13:05:02 + git push binary_tmp@147.75.72.255:binary_tmp.git +jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd
13:05:03 remote: fatal: bad object refs/heads/jenkins-node-test-commit-arm-fanned-44627007be7eb3934e39bdd3df7e8f2556a2cd44-binary-pi1p/cc-armv7        
13:05:03 fatal: bad object refs/heads/jenkins-node-test-commit-arm-fanned-44627007be7eb3934e39bdd3df7e8f2556a2cd44-binary-pi1p/cc-armv7
13:05:03 To 147.75.72.255:binary_tmp.git
13:05:03  ! [remote rejected]         jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd -> jenkins-node-test-commit-windows-fanned-e71525d18c4b7f2241bdf6654d7993930d51bcfd (missing necessary objects)
13:05:03 error: failed to push some refs to 'binary_tmp@147.75.72.255:binary_tmp.git'

Unfortunately node-test-commit-arm-fanned and node-test-commit-windows-fanned are going to be broken until this is resolved. I've opened nodejs/build#3475 -- I won't be able to log onto the machine until Tuesday but maybe someone else with access will be able to take a look before then.

As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference.

tniessen · 2023-08-29T19:37:48Z

Should work now, hopefully. The problem on Windows appears to be that, while most modern operating systems resolve symlinks while parsing a path, Windows doesn't. Literal UNC paths seem to bypass normalization on Windows, but they are subject to other restrictions that are incompatible with the test.

nodejs-github-bot · 2023-08-30T12:47:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53641/

tniessen · 2023-08-30T18:41:55Z

@nodejs/security-wg This needs to be re-approved.

nodejs-github-bot · 2023-08-31T06:59:01Z

Landed in a81d5e1

As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference. PR-URL: #49155 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference. PR-URL: nodejs#49155 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 13, 2023

tniessen mentioned this pull request Aug 13, 2023

doc: clarify pm limitations and include symlink statement #49153

Closed

RafaelGSS self-requested a review August 14, 2023 00:35

RafaelGSS approved these changes Aug 14, 2023

View reviewed changes

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2023

This comment was marked as outdated.

Sign in to view

tniessen force-pushed the doc_test-pm-path-resolution branch from 517748a to 946da0a Compare August 21, 2023 14:43

tniessen added request-ci Add this label to start a Jenkins CI on a PR. security Issues and PRs related to security. permission Issues and PRs related to the Permission Model doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Aug 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2023

This comment was marked as outdated.

Sign in to view

This was referenced Aug 22, 2023

CI Reliability 2023-08-22 nodejs/reliability#642

Open

CI Reliability 2023-08-23 nodejs/reliability#643

Open

This comment was marked as outdated.

Sign in to view

tniessen added the review wanted PRs that need reviews. label Aug 23, 2023

This was referenced Aug 24, 2023

CI Reliability 2023-08-24 nodejs/reliability#644

Open

CI Reliability 2023-08-25 nodejs/reliability#645

Open

CI Reliability 2023-08-26 nodejs/reliability#646

Open

CI Reliability 2023-08-27 nodejs/reliability#647

Open

RafaelGSS reviewed Aug 27, 2023

View reviewed changes

test/known_issues/test-permission-model-path-resolution.js Outdated Show resolved Hide resolved

test/known_issues/test-permission-model-path-resolution.js Outdated Show resolved Hide resolved

tniessen force-pushed the doc_test-pm-path-resolution branch from 946da0a to e71525d Compare August 27, 2023 09:54

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2023

This comment was marked as outdated.

Sign in to view

This was referenced Aug 28, 2023

CI Reliability 2023-08-28 nodejs/reliability#648

Open

CI Reliability 2023-08-29 nodejs/reliability#649

Open

This comment was marked as outdated.

Sign in to view

tniessen force-pushed the doc_test-pm-path-resolution branch from e71525d to 5f4527e Compare August 29, 2023 19:32

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Aug 30, 2023

CI Reliability 2023-08-30 nodejs/reliability#650

Open

16 tasks

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Aug 31, 2023

CI Reliability 2023-08-31 nodejs/reliability#651

Open

18 tasks

RafaelGSS approved these changes Aug 31, 2023

View reviewed changes

tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Aug 31, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2023

nodejs-github-bot merged commit a81d5e1 into nodejs:main Aug 31, 2023

UlisesGascon mentioned this pull request Sep 10, 2023

v20.7.0 proposal #49592

Merged

tniessen mentioned this pull request Jan 17, 2024

Incorrect normalization of POSIX paths with exactly two leading slashes #51345

Open

Uh oh!

Conversation

tniessen commented Aug 13, 2023

Uh oh!

nodejs-github-bot commented Aug 13, 2023

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

tniessen commented Aug 27, 2023

Uh oh!

richardlau commented Aug 27, 2023

Uh oh!

This comment was marked as outdated.

tniessen commented Aug 29, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 30, 2023

Uh oh!

tniessen commented Aug 30, 2023

Uh oh!

nodejs-github-bot commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants