doc: ecma version switcher#4915
Closed
eljefedelrodeodeljefe wants to merge 2 commits intonodejs:masterfrom
eljefedelrodeodeljefe:es-switcher
Closed
doc: ecma version switcher#4915eljefedelrodeodeljefe wants to merge 2 commits intonodejs:masterfrom eljefedelrodeodeljefe:es-switcher
eljefedelrodeodeljefe wants to merge 2 commits intonodejs:masterfrom
eljefedelrodeodeljefe:es-switcher
Conversation
Contributor
|
The resolution on this from the Docs WG was that we weren't going to implement this approach due to the maintenance burden of providing two examples for every existing example in the docs, but instead look into better highlighting for ES2015 syntax. |
Contributor
|
(For posterity: the resolution.) Edit: Sorry for the confusion. I didn't think to comment on the adjoining nodejs.org issue when posting the resolution from the Docs WG meeting, so the resolution didn't get to all of the places it needed to be — mea culpa! |
Contributor
Author
|
A pity. Thanks. |
This was referenced Apr 18, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked up from @rvagg's very nice es-swicher on nodejs/nodejs.org#467
This PR adds a switchable box to the docs, with which the user can switch between ecmascript versions. Though this must be extended for an n-th iteration of ecmascript the soulution would be quite clean: The markdown just duplicates content linearly and old browser potentially just render two boxes.
cc/ @nodejs/documentation
TODOs: