test: add tmpdir.fileURL()

[LiviaMedeiros]

Almost every time tmpdir.path is used in tests, we have to import path to use it.
Whenever we need URL of something in tmpdir, we also have to import url.pathToFileURL.
Adding tmpdir.url would reduce

import { join } from 'node:path';
import { pathToFileURL } from 'node:url';
const testFile = pathToFileURL(join(tmpdir.path, 'subdir', 'tst-file-123'));

to

const testFile = tmpdir.resolve('subdir', 'tst-file-123');

or to native resolving

const tmpBase = tmpdir.fileURL();
const testFile = new URL('subdir/tst-file-123', tmpBase);

Additionally, maybe we could add path-oriented tmpdir.resolve(...paths) to replace path.join(tmpdir.path, ...paths) in tests?

[tniessen]

Why is the URL not a URL?

[LiviaMedeiros]

Why is the URL not a URL?

For consistency with import.meta.url and general guideline. No strong opinion here.

[tniessen]

I see. For anyone else wondering the same thing, it sounds like the main issue is that URL is meant to be mutable, which is undesirable for values that are not meant to be modified.

[aduh95]

We could have tmpdir.fileURL() which would return a new URL instance, and would accept a relative URL as optional parameter, that would be consistent with fixtures.mjs. wdyt?

[joyeecheung]

Considering we also already have fixtures.fileURL() and fixtures.path() I think tmpdir.fileURL() and tmpdir.resolve() (because tmpdir.path is already taken) would make a lot of sense (I've always wondered why we don't have tmpdir.resolve() whenever I have to do path.join(tmpdir.path))

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53136/

[nodejs-github-bot]

Landed in 7bbcb29