[v18.x backport] lib: implement AbortSignal.any()#48800
Closed
atlowChemi wants to merge 2 commits intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] lib: implement AbortSignal.any()#48800atlowChemi wants to merge 2 commits intonodejs:v18.x-stagingfrom
atlowChemi wants to merge 2 commits intonodejs:v18.x-stagingfrom
Conversation
nodejs-github-bot
added
needs-ci
atlowChemi
commented
Jul 16, 2023
Member
Author
There was a problem hiding this comment.
not sure if this change is really related / wanted here
atlowChemi
added
the
abortcontroller
PR-URL: nodejs#47821 Fixes: nodejs#47811 Refs: whatwg/dom#1152 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
atlowChemi
force-pushed
the
v18-backport-abortSignal.any
branch
from
4e57bf1 to
a30ecab
Compare
atlowChemi
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
danielleadams
approved these changes
Jul 17, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 17, 2023
PR-URL: #47821 Backport-PR-URL: #48800 Fixes: #47811 Refs: whatwg/dom#1152 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Contributor
|
Landed in d002f9b...156292d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #47821, #48448