test: fix test-child-process-pipe-dataflow#48331
Conversation
dfe256d to
583f7e6
Compare
|
By the way the test passes with |
Yep. passed by me locally on a windows vm as well |
|
And it used to pass on Jenkins until a few days ago |
|
this fix only fixes the issue for some windows versions: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/21245/ |
|
As an option for quickfix 🩹 it would be the use of |
|
I think we can implement |
|
I think that invalidates the original intention of the test as we could do the same for |
|
Well I guess the best solution is to figure out why |
|
Or mark it flaky until we do :). |
|
IMO, |
Fixes: #48300
seems like something changed in the Windows machines causing wc to behave differently
changed from
wc -c(count bytes) towc -m(count characters).