doc: updated process.versions properties#48019
doc: updated process.versions properties#48019nodejs-github-bot merged 1 commit intonodejs:mainfrom Basa198:docsUpdatedprocess.versions
Conversation
debadree25
left a comment
There was a problem hiding this comment.
I think we could replace the entire output with what the latest version of node gives?
{
node: '19.8.1',
acorn: '8.8.2',
ada: '1.0.4',
ares: '1.19.0',
brotli: '1.0.9',
cldr: '42.0',
icu: '72.1',
llhttp: '8.1.0',
modules: '111',
napi: '8',
nghttp2: '1.52.0',
openssl: '1.1.1t',
simdutf: '3.2.2',
tz: '2022e',
undici: '5.21.0',
unicode: '15.0',
uv: '1.44.2',
uvwasi: '0.0.16',
v8: '10.8.168.25-node.12',
zlib: '1.2.11'
}There's a small difference that node now prints everything alphabetically ordered
|
Here's the output with I think we should take it and replace |
|
Thanks for commenting, could you please give more instructions? Should I update the |
|
Hey! You can just copy and paste @targos soln in the doc |
|
Great! Thank you for being so helpful |
deokjinkim
left a comment
There was a problem hiding this comment.
Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.
Fixes: https://github.com/nodejs/node/issues/48016
You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
doc/api/process.md
Outdated
| icu: '63.1', | ||
| tz: '2018e', | ||
| unicode: '11.0' } | ||
| { node: '21.0.0-pre', |
There was a problem hiding this comment.
As @targos mentioned, please replace '21.0.0-pre' with 20.2.0.
| { node: '21.0.0-pre', | |
| { node: '20.2.0', |
deokjinkim
left a comment
There was a problem hiding this comment.
Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.
Fixes: https://github.com/nodejs/node/issues/48016
You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
|
Thanks for input, anything else? |
For now, first commit's subsystem( |
|
Landed in 1fdcb1c |
Added process.versions properties in docs:
uvwasiundiciacornbase64cjs_module_lexerBefore
After
Fixes: #48016