test: fix webcrypto wrap unwrap tests#47876
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 7, 2023
Merged
Conversation
panva
added
crypto
tniessen
approved these changes
May 5, 2023
panva
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
Note: the tests did actually execute before, but would cause an unhandled rejection in the file if they failed instead of reporting properly. |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
lpinca
approved these changes
May 5, 2023
panva
added
the
commit-queue
This was referenced May 6, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ecf1427 |
This was referenced May 8, 2023
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Refs: nodejs#47864 PR-URL: nodejs#47876 Refs: nodejs#47864 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrap/unwrap promises are now properly handled.
Refs: #47864
cc @tniessen @fhanau