url: reduce revokeObjectURL cpp calls#47728
Merged
nodejs-github-bot merged 1 commit intomainfrom Apr 30, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
force-pushed
the
perf-revoke-object-url
branch
from
0b485ec to
e67eafd
Compare
lemire
reviewed
Apr 26, 2023
anonrig
force-pushed
the
perf-revoke-object-url
branch
from
e67eafd to
3e6638b
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
approved these changes
Apr 26, 2023
anonrig
added
the
author ready
Collaborator
35 tasks
debadree25
approved these changes
Apr 27, 2023
This was referenced Apr 28, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6827dbb |
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Apr 30, 2023
debadree25
added a commit
to debadree25/node
that referenced
this pull request
Apr 30, 2023
This was referenced May 1, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47728 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47728 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving a pending TODO. This pull request mainly reduces the C++ calls in revokeObjectURL function while removing the
try/catchblock.cc @nodejs/url