bootstrap: store internal loaders in C++ via a binding#47215
Closed
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Closed
bootstrap: store internal loaders in C++ via a binding#47215joyeecheung wants to merge 2 commits intonodejs:mainfrom
joyeecheung wants to merge 2 commits intonodejs:mainfrom
Conversation
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
reviewed
Mar 22, 2023
legendecas
approved these changes
Mar 22, 2023
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
LGTM. This looks much simpler without special handling.
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
Linter is complaining. |
Collaborator
Collaborator
Collaborator
Member
|
@nodejs/startup could we have another review on this? |
legendecas
added
author ready
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Landed in c81e114 |
legendecas
pushed a commit
that referenced
this pull request
Mar 29, 2023
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: #47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
legendecas
removed
the
commit-queue-failed
18 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: #47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: #47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
|
Hi @joyeecheung! I had to drop #46809 and this PR isn't landing cleanly on v19.x-staging. Can you please create a manual backport? If it strictly depends on #46809 feel free to change the label to |
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: #47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: nodejs/node#47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script. PR-URL: nodejs/node#47215 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning the internal loaders from the bootstrap script, we can simply call a binding to store them in C++. This eliminates the need for specializing the handling of this script.