meta: add single-executable labels and code owners#47004
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 10, 2023
Merged
meta: add single-executable labels and code owners#47004nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
joyeecheung
added
the
single-executable
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
aduh95
approved these changes
Mar 8, 2023
RaisinTen
approved these changes
Mar 9, 2023
Member
|
Also, cc @nodejs/single-executable |
Co-authored-by: Darshan Sen <raisinten@gmail.com>
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47004 ✔ Done loading data for nodejs/node/pull/47004 ----------------------------------- PR info ------------------------------------ Title meta: add single-executable labels and code owners (#47004) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:sea-pr -> nodejs:main Labels meta, author ready, single-executable Commits 2 - meta: add single-executable labels and code owners - fixup! meta: add single-executable labels and code owners #47004 Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/47004 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47004 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 08 Mar 2023 00:27:16 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/47004#pullrequestreview-1330210062 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47004#pullrequestreview-1332078736 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47004 From https://github.com/nodejs/node * branch refs/pull/47004/merge -> FETCH_HEAD ✔ Fetched commits as bcebb914f59e..d20d6430f6d7 -------------------------------------------------------------------------------- [main e327777f87] meta: add single-executable labels and code owners Author: Joyee Cheung Date: Tue Mar 7 23:27:56 2023 +0100 2 files changed, 4 insertions(+) [main d6b674b7ea] fixup! meta: add single-executable labels and code owners #47004 Author: Joyee Cheung Date: Thu Mar 9 11:38:10 2023 +0100 1 file changed, 7 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4380167036 |
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 1ccc8cc |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #47004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also created the
single-executablelabel -> (hopefully there's no objection to that ;))