lib: Remove XXX comment in readline and change to output debuglog#4690
Closed
kohei-takata wants to merge 1 commit intonodejs:masterfrom
Closed
lib: Remove XXX comment in readline and change to output debuglog#4690kohei-takata wants to merge 1 commit intonodejs:masterfrom
kohei-takata wants to merge 1 commit intonodejs:masterfrom
Conversation
lib/readline.js
Outdated
Member
There was a problem hiding this comment.
Congratulations your 1st contribution.
You would be better to print more information. e.g.
debug('tab complete error ', err);like https://github.com/nodejs/node/blob/master/lib/repl.js#L230
yosuke-furukawa
added
the
good first issue
Fishrock123
added
readline
Contributor
|
@kohei-takata Could you please prefix the commit message with Also please make sure the commit message (the first line, where the prefix is) is no longer than 50 characters. :) |
Member
|
LGTM with the nits @Fishrock123 and @yosuke-furukawa mentioned addressed. |
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error.
kohei-takata
force-pushed
the
remove_xxx_in_readline
branch
from
d506391 to
a854ec6
Compare
Contributor
Author
|
@yosuke-furukawa @Fishrock123 @jasnell |
Contributor
|
LGTM pending CI |
Contributor
Member
|
Failures in CI look unrelated. Updated commit LGTM |
Member
|
CI is a little more robust right now then it was 13 hours ago, so let's try CI again: |
Member
|
CI is green! \o/ |
Member
|
Great job @Trott. Great to see.
|
Contributor
Author
|
@Trott Thanks! |
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in ad63d35 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 18, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: nodejs#4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #4642
Remove a comment that has a word 'XXX'.
And add a line to output debuglog of error.