deps: copy postject-api.h and LICENSE to the deps folder#46582
Closed
RaisinTen wants to merge 2 commits intonodejs:mainfrom
Closed
deps: copy postject-api.h and LICENSE to the deps folder#46582RaisinTen wants to merge 2 commits intonodejs:mainfrom
postject-api.h and LICENSE to the deps folder#46582RaisinTen wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: nodejs#45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
deps/copy-postject-api-and-license-to-the-deps-folder
branch
from
54baca1 to
2c626f5
Compare
Member
Author
|
Although this has the
needs-ci
|
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Feb 9, 2023
anonrig
reviewed
Feb 9, 2023
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
approved these changes
Feb 9, 2023
RaisinTen
added
the
author ready
lpinca
approved these changes
Feb 9, 2023
RaisinTen
removed
the
fast-track
tony-go
approved these changes
Feb 10, 2023
RaisinTen
added a commit
that referenced
this pull request
Feb 11, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in a37c083 |
RaisinTen
deleted the
deps/copy-postject-api-and-license-to-the-deps-folder
branch
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Apr 10, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: nodejs#45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Since `postject-api.h` gets compiled into Node.js, it makes more sense to put it in the `deps` directory instead of `test/fixtures`. Refs: #45038 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46582 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RaisinTen
added
the
single-executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
postject-api.hgets compiled into Node.js, it makes more sense to put it in thedepsdirectory instead oftest/fixtures.Refs: #45038 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @mhdawson @nodejs/single-executable