lib: predeclare Event.isTrusted property descriptor#46527
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 8, 2023
Merged
lib: predeclare Event.isTrusted property descriptor#46527nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
lpinca
approved these changes
Feb 6, 2023
anonrig
approved these changes
Feb 6, 2023
Collaborator
mscdex
reviewed
Feb 6, 2023
UlisesGascon
approved these changes
Feb 6, 2023
7e0185e to
c64f53a
Compare
BridgeAR
approved these changes
Feb 6, 2023
aduh95
reviewed
Feb 6, 2023
It improves Event creation performance.
c64f53a to
2820ee9
Compare
aduh95
approved these changes
Feb 6, 2023
Collaborator
jasnell
approved these changes
Feb 6, 2023
Contributor
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1294/ Results |
cjihrig
approved these changes
Feb 7, 2023
RafaelGSS
approved these changes
Feb 8, 2023
Collaborator
|
Landed in 85c8b78 |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
It improves Event creation performance. PR-URL: #46527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
It improves Event creation performance. PR-URL: #46527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It improves Event creation performance.
I'm seeing these numbers: