v8: support gc profile by theanarkh · Pull Request #46255 · nodejs/node

theanarkh · 2023-01-18T16:33:30Z

support gc profile. the content is as follows.

{
  "version": 1,
  "startTime": 1674059033862,
  "statistics": [
    {
      "gcType": "Scavenge",
      "beforeGC": {
        "heapStatistics": {
          "totalHeapSize": 5005312,
          "totalHeapSizeExecutable": 524288,
          "totalPhysicalSize": 5226496,
          "totalAvailableSize": 4341325216,
          "totalGlobalHandlesSize": 8192,
          "usedGlobalHandlesSize": 2112,
          "usedHeapSize": 4883840,
          "heapSizeLimit": 4345298944,
          "mallocedMemory": 254128,
          "externalMemory": 225138,
          "peakMallocedMemory": 181760
        },
        "heapSpaceStatistics": [
          {
            "spaceName": "read_only_space",
            "spaceSize": 0,
            "spaceUsedSize": 0,
            "spaceAvailableSize": 0,
            "physicalSpaceSize": 0
          }
        ]
      },
      "cost": 1574.14,
      "afterGC": {
        "heapStatistics": {
          "totalHeapSize": 6053888,
          "totalHeapSizeExecutable": 524288,
          "totalPhysicalSize": 5500928,
          "totalAvailableSize": 4341101384,
          "totalGlobalHandlesSize": 8192,
          "usedGlobalHandlesSize": 2112,
          "usedHeapSize": 4059096,
          "heapSizeLimit": 4345298944,
          "mallocedMemory": 254128,
          "externalMemory": 225138,
          "peakMallocedMemory": 181760
        },
        "heapSpaceStatistics": [
          {
            "spaceName": "read_only_space",
            "spaceSize": 0,
            "spaceUsedSize": 0,
            "spaceAvailableSize": 0,
            "physicalSpaceSize": 0
          }
        ]
      }
    }
  ],
  "endtTime": 1674059036865
}

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

src/node_v8.cc

doc/api/v8.md

lib/v8.js

src/node_v8.cc

src/node_v8.h

src/node_v8.cc

doc/api/v8.md

lib/v8.js

src/node_v8.cc

test/common/v8.js

test/parallel/test-v8-take-gc-profile-exit-before-stop.js

test/parallel/test-v8-take-gc-profile-in-worker.js

test/parallel/test-v8-take-gc-profile.js

doc/api/v8.md

jasnell · 2023-01-20T02:27:30Z

The perf_hooks module already has a PerformanceEntry type for GC operations. I'm wondering if it would make more sense to add this additional detail to that existing API than to add an entirely new API.

theanarkh · 2023-01-20T03:27:16Z

The perf_hooks module already has a PerformanceEntry type for GC operations. I'm wondering if it would make more sense to add this additional detail to that existing API than to add an entirely new API.

Every time a GC occurs, perf_hooks will create a new entry and call JS callback later, I'm not sure If this will cause performance problems when GC is frequent, so i think we can implement this in C++. And we can add more informations in this API in the furure, like process.report do, such as GC load.

Currently i think the user can implement GC profile in JS land by combine perf_hooks, v8.getHeapSpaceStatistics() , and v8.getHeapStatistics(). i also try to implement GC load by perf_hooks(nodejs-gc-load), but i am going to implement this in Node.js Core.

nodejs-github-bot · 2023-01-21T14:07:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49119/

nodejs-github-bot · 2023-01-25T03:04:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49159/

nodejs-github-bot · 2023-01-25T09:39:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49165/

nodejs-github-bot · 2023-01-25T12:02:12Z

Landed in 733ef4e

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 deps: * upgrade npm to 9.4.0 (npm team) #46353 esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46455

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Notable Changes buffer: * add isAscii method (Yagiz Nizipli) #46046 fs: * add statfs() functions (Colin Ihrig) #46358 src,lib: * add constrainedMemory API for process (theanarkh) #46218 v8: * support gc profile (theanarkh) #46255 vm: * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: TDB

Notable Changes buffer: * add isAscii method (Yagiz Nizipli) #46046 fs: * add statfs() functions (Colin Ihrig) #46358 src,lib: * add constrainedMemory API for process (theanarkh) #46218 v8: * support gc profile (theanarkh) #46255 vm: * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Notable Changes: buffer: * add isAscii method (Yagiz Nizipli) #46046 fs: * add statfs() functions (Colin Ihrig) #46358 src,lib: * add constrainedMemory API for process (theanarkh) #46218 v8: * support gc profile (theanarkh) #46255 vm: * expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920

Notable Changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: https://github.com/nodejs/node/pull/46920/commits

Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 doc,lib,src,test: * rename --test-coverage (Colin Ihrig) #46017 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * add initial code coverage support (Colin Ihrig) #46017 * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46920

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 18, 2023

theanarkh force-pushed the support_gc_profile branch from c54c984 to 2b5c23c Compare January 18, 2023 16:37

addaleax reviewed Jan 18, 2023

View reviewed changes

src/node_v8.cc Outdated Show resolved Hide resolved

theanarkh force-pushed the support_gc_profile branch 2 times, most recently from cbcd60d to 8a8e086 Compare January 18, 2023 17:57

anonrig reviewed Jan 18, 2023

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

lib/v8.js Outdated Show resolved Hide resolved

src/node_v8.cc Outdated Show resolved Hide resolved

src/node_v8.h Outdated Show resolved Hide resolved

src/node_v8.cc Outdated Show resolved Hide resolved

theanarkh force-pushed the support_gc_profile branch 5 times, most recently from 4756504 to e57ab16 Compare January 19, 2023 06:47

addaleax approved these changes Jan 19, 2023

View reviewed changes

src/node_v8.cc Outdated Show resolved Hide resolved

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 19, 2023

theanarkh force-pushed the support_gc_profile branch 2 times, most recently from ce8dfe7 to ca62c3b Compare January 19, 2023 13:55

VoltrexKeyva reviewed Jan 19, 2023

View reviewed changes

theanarkh force-pushed the support_gc_profile branch from ca62c3b to 7abbe89 Compare January 20, 2023 02:13

jasnell reviewed Jan 20, 2023

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

jasnell reviewed Jan 20, 2023

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

jasnell reviewed Jan 20, 2023

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

theanarkh force-pushed the support_gc_profile branch from 7abbe89 to 334936c Compare January 20, 2023 06:57

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2023

theanarkh requested review from addaleax and jasnell January 22, 2023 04:42

theanarkh force-pushed the support_gc_profile branch from d6b457b to 50a83ff Compare January 24, 2023 16:56

v8: support gc profile

ce2b9fe

theanarkh force-pushed the support_gc_profile branch from 50a83ff to ce2b9fe Compare January 24, 2023 17:01

addaleax approved these changes Jan 24, 2023

View reviewed changes

fhinkel approved these changes Jan 25, 2023

View reviewed changes

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2023

theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023

nodejs-github-bot merged commit 733ef4e into nodejs:main Jan 25, 2023

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023

v8: support gc profile

b4ac794

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

ruyadorno mentioned this pull request Feb 1, 2023

v19.6.0 proposal #46455

Merged

ruyadorno added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 1, 2023

juanarbol pushed a commit that referenced this pull request Mar 3, 2023

v8: support gc profile

fa43929

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

juanarbol mentioned this pull request Mar 3, 2023

V18.15.0 proposal #46920

Merged

juanarbol pushed a commit that referenced this pull request Mar 3, 2023

v8: support gc profile

95d1f59

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

juanarbol pushed a commit that referenced this pull request Mar 5, 2023

v8: support gc profile

02632b4

PR-URL: #46255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Uh oh!

Conversation

theanarkh commented Jan 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jasnell commented Jan 20, 2023

Uh oh!

theanarkh commented Jan 20, 2023

Uh oh!

nodejs-github-bot commented Jan 21, 2023

Uh oh!

nodejs-github-bot commented Jan 25, 2023

Uh oh!

nodejs-github-bot commented Jan 25, 2023

Uh oh!

nodejs-github-bot commented Jan 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants