docs: update to match changed --dns-result-order default#46148
Merged
aduh95 merged 1 commit intonodejs:mainfrom Jan 16, 2023
Merged
docs: update to match changed --dns-result-order default#46148aduh95 merged 1 commit intonodejs:mainfrom
aduh95 merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dns
lpinca
approved these changes
Jan 9, 2023
ShogunPanda
approved these changes
Jan 10, 2023
cjihrig
approved these changes
Jan 10, 2023
aymen94
approved these changes
Jan 11, 2023
Member
|
@tikotzky could you fix the commit message? This can help: https://www.npmjs.com/package/core-validate-commit |
github-actions
bot
removed
the
request-ci
Collaborator
Update documentation to match the changed `--dns-result-order` default value in Node.js 17.
Contributor
Author
|
@mcollina thanks. I updated let me know if it looks ok now. |
This was referenced Jan 12, 2023
Contributor
|
Landed in 8986bf8 |
17 tasks
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
Update documentation to match the changed `--dns-result-order` default value in Node.js 17.0.0. PR-URL: nodejs#46148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
18 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
Update documentation to match the changed `--dns-result-order` default value in Node.js 17.0.0. PR-URL: #46148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Update documentation to match the changed `--dns-result-order` default value in Node.js 17.0.0. PR-URL: #46148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Update documentation to match the changed `--dns-result-order` default value in Node.js 17.0.0. PR-URL: #46148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation to match the changed
--dns-result-orderdefault value in Node.js 17.Seems like this was missed in 816e92e