deps: add simdutf version to metadata#46145
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jan 10, 2023
Merged
Conversation
nodejs-github-bot
added
c++
anonrig
approved these changes
Jan 9, 2023
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
lgtm. thank you for your contribution @roth-mike
anonrig
added
author ready
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
richardlau
approved these changes
Jan 9, 2023
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Jan 9, 2023
anonrig
added
the
commit-queue-squash
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
addaleax
approved these changes
Jan 9, 2023
BridgeAR
approved these changes
Jan 9, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46145 ✔ Done loading data for nodejs/node/pull/46145 ----------------------------------- PR info ------------------------------------ Title deps: add simdutf version to metadata (#46145) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch roth-mike:add-simdutf-version -> nodejs:main Labels c++, fast-track, author ready, needs-ci, commit-queue-squash Commits 2 - deps: add simdutf version to metadata - fixup! deps: add simdutf version to metadata Committers 1 - roth-mike PR-URL: https://github.com/nodejs/node/pull/46145 Reviewed-By: Yagiz Nizipli Reviewed-By: Richard Lau Reviewed-By: Anna Henningsen Reviewed-By: Ruben Bridgewater ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46145 Reviewed-By: Yagiz Nizipli Reviewed-By: Richard Lau Reviewed-By: Anna Henningsen Reviewed-By: Ruben Bridgewater -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 09 Jan 2023 15:53:39 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46145#pullrequestreview-1240784014 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46145#pullrequestreview-1240740709 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46145#pullrequestreview-1241214209 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/46145#pullrequestreview-1241220479 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-09T20:53:01Z: https://ci.nodejs.org/job/node-test-pull-request/48921/ - Querying data for job/node-test-pull-request/48921/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3884878762 |
jasnell
approved these changes
Jan 10, 2023
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9dbb14b |
This was referenced Jan 11, 2023
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46145 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46145 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46145 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46145 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that simdutf version was missing from process.versions. This pull request adds the version.