build: add vtune profiling enabling flag in default Linux buiding CI#46116
build: add vtune profiling enabling flag in default Linux buiding CI#46116lucshi wants to merge 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
|
I'm -1. This is only going to frustrate V8 upgrades more and those are frustrating enough already. VTune support in node depends on V8's vtune support being in good shape but they don't test that regularly. |
This PR is echo for #45248 (comment) .Could you advice if CI is needed or you think it will be good enough that I fix bugs asap when there would be bugs in future? |
|
You're of course welcome to be proactive in sending fixes, those are welcome. CI isn't a good solution because of the aforementioned upstream problem. |
I'm OK to close this PR if no special actions are needed to track whether VTune building is broken. |
|
I'll go ahead and close this then but thanks anyway! |
Added --enable-vtune-profiling into test-linux.yml to avoid building broken when users enable vtune profiling. This check is done in CI and for Linux only so as to make the CI change minimal but effective.