src: simplify NodeBIO::GetMethod initialization#45799
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 11, 2022
Merged
src: simplify NodeBIO::GetMethod initialization#45799nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Make its initialization self-contained to avoid unnecessarily breaking encapsulation.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
anonrig
added
the
author ready
9 tasks
VoltrexKeyva
approved these changes
Dec 10, 2022
anonrig
added
the
commit-queue
JungMinu
approved these changes
Dec 10, 2022
tniessen
approved these changes
Dec 10, 2022
11 tasks
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d498bd9 |
11 tasks
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Dec 12, 2022
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: nodejs#45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
13 tasks
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
12 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
Make its initialization self-contained to avoid unnecessarily breaking encapsulation. PR-URL: #45799 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make its initialization self-contained to avoid unnecessarily breaking encapsulation.