fix: tap parser fails when test name includes non ASCII characters

[pulkit-30]

fixes: #45706

fix: tap parser fails when test name includes non ASCII characters

check for non-ascii characters and return true if it is not.

function to check for non-ASCII characters:

  #isNonASCIISymbol(char) {
    const ascii = /^[ -~]+$/;
    return !ascii.test(char);
  }

Example:

Testing:

// test.mjs
import { it } from 'node:test'
it('नमस्ते', () => {});

Output:

TAP version 13
# Subtest: /Users/pulkitgupta/Desktop/node/test.mjs
    # Subtest: नमस्ते
ok 1 - नमस्ते
    # duration_ms:
ok 1 - /Users/pulkitgupta/Desktop/node/test.mjs
  ---
  duration_ms: 59.161084
  ...
1..1
# tests 1
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 61.073625
pulkitgupta@Pulkits-MacBook-Air node % 

[aduh95]

Can you please add a test to validate this indeed fixes the bug?

[aduh95]

Suggested change

	return !ascii.test(char);
	return RegExpPrototypeExec(ascii, char) === null;

[pulkit-30]

Can you please add a test to validate this indeed fixes the bug?

Sure, Where should I add test ?

[aduh95]

Can you please add a test to validate this indeed fixes the bug?

Sure, Where should I add test ?

test/parallel/test-runner-tap-lexer.js seems adequate.

[MoLow]

@pulkit-30 FYI there is already an open PR fixing this issue #45736

[pulkit-30]

@pulkit-30 FYI there is already an open PR fixing this issue #45736

ohh! I didn't notice that, should I close this PR?

[MoLow]

ohh! I didn't notice that, should I close this PR?

preferably, I see you found another good first issue Issues that are suitable for first-time contributors. to work on - so I am closing