[v18.x backport] backport utf8 performance improvements#45650
Closed
anonrig wants to merge 6 commits intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] backport utf8 performance improvements#45650anonrig wants to merge 6 commits intonodejs:v18.x-stagingfrom
anonrig wants to merge 6 commits intonodejs:v18.x-stagingfrom
Conversation
nodejs-github-bot
added
c++
anonrig
force-pushed
the
backport-utf8-to-v18.x
branch
from
4ad6874 to
c1fd005
Compare
PR-URL: nodejs#45294 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#45363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#45363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#45363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#45388 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: nodejs#45412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
anonrig
force-pushed
the
backport-utf8-to-v18.x
branch
from
c1fd005 to
d86c37f
Compare
Member
|
I appreciate the effort, but v18.x is Active LTS, so all changes should automatically be backported to it by releasers. You can add the |
Member
Author
|
Thanks @targos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first backport. If the time is right, I'd like to backport UTF8 encoding performance improvements, so that LTS users can access to the performance boosts.
I'm trying to backport the following changes to the v18 release line:
TextDecoderperformance #45294