Closed
Conversation
To be able to build x86, x64, and ARM64 MSI installers with the same WiX version, migration to WiX4 is required. These changes use WiX4 preview 1 which is not an official release, but there should be no major changes before WiX4 is GA.
nodejs-github-bot
added
build
Contributor
Author
|
Superseded by #45943. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, two versions of the WiX Toolset are used to build the MSI installers. WiX v3.11 is used for x86 and x64, and WiX v3.14 is used for ARM64. In addition, using any WiX3 version requires it to be installed on the machine. Also, the WiX team is dropping support for v3 and they are encouraging people to move to v4 which had its preview-1 release on 11th November (3 days ago) and is now in the release candidate phase. It depends on a number of issues that get reported and fixed, but generally, WiX4 is expected to be GA in a few months.
This PR aims to migrate Node's MSI installer to WiX4 in order to unify all installers under a single version and remove all dependencies to WiX3 eg. it can be removed from all CI machines. Since WiX4 is still in preview, some changes that may affect this PR are to be expected as well as some changes to the implementation eg. changing from WiX CLI to MSBuild and .wixproj file, but the main goal now is to try these changes in CI and test installers made that way.