Add automation for updating base64 dependency#45300
Add automation for updating base64 dependency#45300nodejs-github-bot merged 1 commit intonodejs:mainfrom facutuesca:base64-ci-update
base64 dependency#45300Conversation
|
Review requested:
|
nodejs-github-bot
added
meta
|
I tried running the script locally to update to 0.5.0, and I see only two modified files. Is it expected? |
Yeah, currently the version of Looking at the commit history of So indeed updating to |
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
It may need to be disabled next time we need to pull a version between releases, but hopefully this won't be needed, and it's certainly better to have it automated in the mean time anyway
tools/update-base64.sh
Outdated
| set -e | ||
| # Shell script to update base64 in the source tree to a specific version | ||
|
|
||
| BASE_DIR="$( pwd )" |
There was a problem hiding this comment.
| BASE_DIR="$( pwd )" | |
| BASE_DIR=$(cd "$(dirname "$0")/.." && pwd) |
This should make it work from anywhere.
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1f51713 |
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: nodejs#45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
There is a Base64 update patch in PR #45091 which is approved but not merged yet. |
@lucshi This script only deals with updating the folder |
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
6 participants
Add a Github Action that checks for new versions of the
base64C library, and creates a PR to update it if a newer version than the one present in the repo is found.Refs: nodejs/security-wg#828