src: fix test runner coverage#45055
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 20, 2022
Merged
Conversation
nodejs-github-bot
added
c++
MoLow
added
coverage
MoLow
force-pushed
the
fix-test-runner-coverage
branch
2 times, most recently
from
1f7f85e to
4e7b6d2
Compare
jasnell
approved these changes
Oct 18, 2022
MoLow
force-pushed
the
fix-test-runner-coverage
branch
from
4e7b6d2 to
e4f6b97
Compare
github-actions
bot
removed
the
request-ci
Collaborator
MoLow
added
the
author ready
benjamingr
approved these changes
Oct 20, 2022
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 54eb543 |
Merged
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Nov 23, 2022
PR-URL: nodejs#45055 Fixes: nodejs#45013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Politely, it would be great if this were found in the stable 18.* series. After porting many tests to use the node native test runner, one must use unstable 19.* to continue getting test coverage |
|
installing the 19.* series and running the tests, the test process continues when tests have failed |
Member
Author
|
node 18 is in the LTS phase so it will be receiving these commits |
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Dec 9, 2022
PR-URL: nodejs#45055 Fixes: nodejs#45013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45013