meta: fix test_runner labeling#44863
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 2, 2022
Merged
Conversation
nodejs-github-bot
added
the
meta
Member
Author
|
CC @nodejs/test_runner |
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
RaisinTen
approved these changes
Oct 2, 2022
jasnell
approved these changes
Oct 2, 2022
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e5c807e |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44863 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are 3 issues fixed by this PR (I tested the changes locally)
doc/api/test.mdwas converted to testlib/test.jswas converted to testlib/internal/test_runner/*only adds https://github.com/nodejs/node/labels/dont-land-on-v14.x but does not add test_runnerexamples:
#44854
#44844
the third issue did not occur yet so there is no example for it