Closed
Conversation
Member
There was a problem hiding this comment.
Guess this test is poorly named if it doesn't use the cluster module.
Member
|
LGTM
I can confirm that. |
Member
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests.
Trott
force-pushed
the
rm-unused-modules
branch
from
831fa73 to
6304758
Compare
Member
Author
|
Rebased and force pushed. |
Member
Author
|
Seemingly unrelated test failure on one of the Raspberry Pi devices, but CI looks good other than that. |
Member
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 2, 2016
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4475 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Member
Author
|
Landed in 6abd8b5 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4475 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Contributor
|
@Trott this is merging with conflicts on v4.x-staging would you be able to take a look? |
Member
Author
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Many tests use require() to import modules that subsequently never gets used. This removes those imports and, in a few cases, removes other unused variables from tests. PR-URL: nodejs#4475 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many tests use
require()to import modules that subsequently never getsused. This removes those imports and, in a few cases, removes other
unused variables from tests.
I'm especially looking for review on the tests in
test/pummelas I'm not 100% clear on how those tests work. It seems like a number of them were failing already prior to these changes (judging from results runningmake test-pummelon OS X).