doc: update node prefix require.cache example#44724
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 2, 2022
simoneb:docs-require-cache
Merged
doc: update node prefix require.cache example#44724nodejs-github-bot merged 1 commit intonodejs:mainfrom simoneb:docs-require-cache
nodejs-github-bot merged 1 commit intonodejs:mainfrom
simoneb:docs-require-cache
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
GeoffreyBooth
approved these changes
Sep 19, 2022
lpinca
approved these changes
Sep 19, 2022
marsonya
approved these changes
Sep 20, 2022
RaisinTen
approved these changes
Sep 20, 2022
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
nit: using fix instead of update in the title sounds more appropriate IMO because the previous code is incorrect as it runs into an assertion error
tniessen
approved these changes
Sep 22, 2022
daeyeon
added
commit-queue
jasnell
approved these changes
Oct 2, 2022
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8f16a8c |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44724 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be more intuitive if the docs showed passing assertions