lib: add cause to DOMException#44703
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 4, 2022
Merged
Conversation
flakey5
force-pushed
the
flakey5/add-domexception-cause
branch
from
400012e to
c871867
Compare
jasnell
reviewed
Sep 17, 2022
jasnell
reviewed
Sep 17, 2022
aduh95
reviewed
Sep 18, 2022
flakey5
force-pushed
the
flakey5/add-domexception-cause
branch
from
ff4713f to
a81a794
Compare
aduh95
reviewed
Sep 18, 2022
flakey5
force-pushed
the
flakey5/add-domexception-cause
branch
from
a81a794 to
7fc758b
Compare
jasnell
reviewed
Sep 21, 2022
flakey5
force-pushed
the
flakey5/add-domexception-cause
branch
from
3c85e9a to
004fb4c
Compare
flakey5
force-pushed
the
flakey5/add-domexception-cause
branch
from
004fb4c to
261bbb2
Compare
Collaborator
aduh95
approved these changes
Oct 2, 2022
legendecas
reviewed
Oct 2, 2022
Member
|
While @flakey5 is working on remembering his password to log into GitHub from his phone ;-)... When we were discussing this change we noticed that the documentation for DOMException only links to MDN. It doesn't break down any of the API. I agree we should have docs but I'd prefer to do that in a separate PR that covers all of DOMException. |
legendecas
approved these changes
Oct 3, 2022
Member
legendecas
left a comment
legendecas
left a comment
There was a problem hiding this comment.
Sounds good to me. Thanks.
Collaborator
16 tasks
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 00e5617 |
panva
pushed a commit
to panva/node
that referenced
this pull request
Oct 4, 2022
PR-URL: nodejs#44703 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
19 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44703 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
causefield to DOMException as per the WebIDL standard added in whatwg/webidl#1179@jasnell @panva