dns: remove unnecessary parameter from validateOneOf#44635
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 17, 2022
Merged
dns: remove unnecessary parameter from validateOneOf#44635nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dns
cola119
approved these changes
Sep 14, 2022
daeyeon
approved these changes
Sep 14, 2022
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Sep 14, 2022
LiviaMedeiros
approved these changes
Sep 14, 2022
This comment was marked as outdated.
This comment was marked as outdated.
29 tasks
Collaborator
marsonya
approved these changes
Sep 15, 2022
aduh95
added
the
author ready
This was referenced Sep 16, 2022
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 572d556 |
This was referenced Sep 18, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44635 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44635 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
PR-URL: #44635 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Member
|
This is making changes over a semver-major change that did not land in the v16.x release line. Marking as dont-land-on-v16.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateOneOfonly takes 3 arguments, not 4.